YesNoOk

Show content

This section allows you to browse the content for this member. Note that you can only see content for which you have sufficient viewing permissions.

*
Nightwish is Offline
Contact Nightwish:

Nightwish

Administrator

Messages by Nightwish

    
Re: Test test
 August 08, 2012, 15:57:58 View in topic context
 Posted by Nightwish  in Test test (Started by Dr. Deejay October 07, 2011, 17:35:18
 Board: Testing Board

Most of the BBCode changes have not (yet) made it into the editor. This is also true for new bbc tags like [css] and all the [h] tags.

The editor needs a big overhaul and I'm considering using something completely different, like this one.
    
Re: Test test
 August 08, 2012, 09:09:35 View in topic context
 Posted by Nightwish  in Test test (Started by Dr. Deejay October 07, 2011, 17:35:18
 Board: Testing Board

[center]Center bbc code not working[/center]

[right]Right bbc code not working[/right]
They are not working because they do no longer exist.
it's now:

[align=left], [align=right], [align=justify]

One bbcode instead of three (= faster)

Quite a lot of SMF bb codes were removed, but there is a plugin that can add them back for full BBCode compatibility with SMF.
1 Useful  | 1 Thank You 
    
Re: minor things
 August 07, 2012, 08:30:48 View in topic context
 Posted by Nightwish  in minor things (Started by Valodim July 27, 2012, 11:26:30
 Board: EosAlpha Bulletin Board System - development

I don't think that check is necessary.
Still not 100% sure, but you're probably right. I tried to break in with all kind of scary pm requests - no success even with admin privileges. What bothers me a bit is that this code was explicitly written for the conversation view, so it's not a leftover from old code.

About today's commit(s): Lots of stuff again, mostly in the pm system. Template conversion goes fine and there are only 2 really big ones left - the profile stuff and the post.template (+a couple of smaller ones).

You may want to take care when merging Subs-Editor.php because of the new buttons.


     Posted: August 10, 2012, 18:36:33
Some heads for upcoming changes...

I've started splitting (and somewhat cleaning up) the main style sheets. To make things easier for theme designers, the main css will be split into two files:
  • base.css - contains only layout-related things, like margins, positions, list layouts and similar.
  • skin_themevariantname.css - contains all the fonts, colors, gradients, images and such.
The base.css is loaded first, so the skin stylesheet can override things in the base if needed. This should it make easier to create color variants without affecting the layout too much and will support the concept of theme variants (as defined in theme_support.php) which act as sub-styles of the current theme.

Basically, you could leave everything in base.css and create a empty skin_default.css (or do it vice versa and keep everything in skin_default.css and create an empty base.css), if you have already customized the css too much.

Other things implemented
  • Auto-sizing textareas for quick reply and inline-modify. It will initially start small and automatically expand or shrink wile typing a message.
  • New profile option for setting the initial size of the full post editor that replaces the stupid resizing bar which didn't work on all browsers and did not remember its setting.

This stuff should be committed later this day (or maybe on the weekend).
1 Useful 
    
Re: minor things
 August 06, 2012, 22:17:24 View in topic context
 Posted by Nightwish  in minor things (Started by Valodim July 27, 2012, 11:26:30
 Board: EosAlpha Bulletin Board System - development

PersonalMessages.php line 710, that one is a huge bug because notifications link to pms which are not the head of a conversation. Also, why shouldn't a user be allowed to see a conversation if the selected pm is not the head of it?
Need to investigate this, there might very well be a good reason for this code. This code is in SMF 2.0 and 2.1 (development branch) as well, but I can see how it conflicts with the notifications.
    
Re: minor things
 August 05, 2012, 16:34:30 View in topic context
 Posted by Nightwish  in minor things (Started by Valodim July 27, 2012, 11:26:30
 Board: EosAlpha Bulletin Board System - development

found the cause for the broken preview - my report borad modification added an empty line after the ?> in Error.english.php :)
also, for the record, php ignores a newline after ?> at the end of files automagically. that's not really consistent behavior, but it allowed xml to work even when there were all those ?>s around
For some reason, it doesn't always work - sometimes, the new lines sneak into the output and ruin xml responses. This is a mess and the worst thing is that these empty lines sneak in before the output buffer is sent, so trimming the buffer doesn't help either.
Quote
the description for merging of posts in the admin panel is wrong: it says the number of minutes determines the maximum age of the last post for the merge. in the implementation, it's actually the maximum age for the last post to perform merging whether the user checked the box or not. both ways make sense I guess, but they should be coherent ;)
There should be a permission to prevent users from un-checking the merge box and force them into merging.

BTW:

https:/..../forum/Themes/mfg/css/index_lightweight.css?v=1572

returns 404?

mfg theme broken for me...
    
Re: minor things
 August 05, 2012, 11:48:38 View in topic context
 Posted by Nightwish  in minor things (Started by Valodim July 27, 2012, 11:26:30
 Board: EosAlpha Bulletin Board System - development

I use luakit so it's libwebkit rendering, here's a shot.
What I expected - it's browser specific what toLocaleTimeString() returns. Guess, I've to find another way to get a locale-aware time format (not so easy in JavaScript).

      Posted: August 05, 2012, 10:57:49
Quote
the pm layout gets really cramped at 1024 pixels width, which is a resolution that should still be supported. maybe put the messages on the full screen width below the menu and pm list?

I didn't give it a shot yet because the change is non-trivial with how the template is stacked right now (and it's going to be converted soon anyways I guess)
PMs will just get a different postbit layout anyway (one without a wide left column, because it's the left column that eats too much space.

BTW: This fix in Load.php is important to avoid tons of warnings about undefined in the log when using a custom theme.

     Posted: August 05, 2012, 14:06:50
Ok...

New time formatting code should be in here...

It should now recognize the member's PHP-style time format (set in the profile) and output either 24hr or 12hr AM/PM time stamps without seconds or time zone information.
    
Re: minor things
 August 05, 2012, 01:07:25 View in topic context
 Posted by Nightwish  in minor things (Started by Valodim July 27, 2012, 11:26:30
 Board: EosAlpha Bulletin Board System - development

huge timestamps right now with GMT+2 stuff, probably just a temporary state during development~
Screenshots, browser version?
It's now using toLocaleTimeString() method and I'm seeing normal timestamps over there...
Quote
do you have plans to show more events in a user's activity stream? most significantly, topic reply notifications?
Yup, activity stream can be used for all kind of things, you already can get notifications when someone posts a reply (but by default, this kind of notification is disabled). Also, members can opt-out from creating activities (I think, that's a privacy thing and should be allowed).

More interesting would be a 'your message has been quoted' notification...

BTW: There is one important fix in one of the last commits to load theme_support.php from the default theme if the custom theme doesn't have one.

And I still get xml responses with empty lines at the beginning - weird, ob_sessrewrite() now does a ltrim() on the buffer - have tested it here on my server and it works, at least when I deliberately insert blank lines in the xml templates.
    
Re: minor things
 August 04, 2012, 14:52:03 View in topic context
 Posted by Nightwish  in minor things (Started by Valodim July 27, 2012, 11:26:30
 Board: EosAlpha Bulletin Board System - development

suggestion for short user agent: shorten_subject(substr($url['USER_AGENT'], 0, strpos($url['USER_AGENT'], ' ')), 25) that will shorten to something like "Mozilla/5.0" or "Opera/9.8"
Done (and when you click on the shortened version, you see the full one).
Quote
About the group colors, I actually meant that the css identifier is wrong, it targets the element group_1 instead of class .group_1
Will be in the next commit.
Quote
here's a bit for your wiki, I just used the second query to convert the msn profile field. first is just for reference.
Thanks. Guess that would also work for the other removed profile fields...
    
Re: minor things
 August 04, 2012, 14:11:26 View in topic context
 Posted by Nightwish  in minor things (Started by Valodim July 27, 2012, 11:26:30
 Board: EosAlpha Bulletin Board System - development

it would, if the styles were set as "a.member .group_1" instead of "a.member group_1" ;)
actually it doesn't that way either :P
The inline styles are regenerated when you modify a member group in the admin panel (for a fresh install, they would be pre-populated in the db).

(Yes, I know, a updater script would be awesome :) )
    
Re: minor things
 August 04, 2012, 12:33:45 View in topic context
 Posted by Nightwish  in minor things (Started by Valodim July 27, 2012, 11:26:30
 Board: EosAlpha Bulletin Board System - development

you probably already noticed, but you used "on" instead of "bind" in bbc_refresh, which breaks spoilers and other things :)
Ups... because the bundled jQuery is still an older one. You can enable the option to load jQuery from Google's CDN which has already been told to fetch 1.7.2. It will also save you some traffic :)

The bundled was still at 1.6, probably forgot to update it.
Quote
Quote
BTW: there is now a way to easily override css. In theme_support.php, you can define a css file name (one per theme variant), put that file in the theme's css folder and it will be loaded *after* the main style sheet.

yeah I hope to get there some time, right now I need a couple of template changes as well. ah well, diff-updating is fairly painless at this point :)
You could use template overrides (should already work).. See Themes/default/tpl/overrides/readme, so in theory, you could simply use the default theme and customize it via css- and template overrides. Depending on the scale of template changes, merging could still be a pain, I know.

Also, some heads up because of this, though it should not break things. Unless you explicitly enable this in Membergroups->Settings, it will dynamically build an inline style sheet using the old colors.
    
Re: New BBCode tags
 August 04, 2012, 09:20:18 View in topic context
 Posted by Nightwish  in New BBCode tags (Started by Nightwish October 04, 2011, 18:28:09
 Board: Showcase

Test spoiler tags with parameters

Format:
[spoiler=title]content[/spoiler]
Spoiler: This is the title (click to see content)
Format of the title can be changed by modifying $txt['spoiler_intro'] in index.english.php. It has to be a valid printf()-style formatting string.
3 Like It  | 2 Thank You 
    
Planned changes in how membergroup colors are handled
 August 03, 2012, 14:41:50 View in topic context

In SMF, member groups can have a color assigned by defining a html color code for the group.

While this is fine in most cases, it has one particular problem: What if you have 2 different themes, say one with a very bright and another one with a dark background? The member group colors that are looking good on the bright theme may totally fail on the dark one (or vice versa).

Solution? Do away with the static colors and let do CSS the magic. Instead of using static style="color:xxx" attributes, CSS classes will be used for member links, so a member link will look like this:
Code: (html)
<a class="member group_#">Membername</a>
Where # is the numeric id of the member's primary group (or group id of his post-based group, if he wasn't assigned a primary one).

In the theme's style sheet it's then just a matter of defining additional CSS classes for non-standard member groups.
Code: (css)
a.member.group_1 {
  color:red;
  font-weight:bold;   /* evil admin will always appear in red and bold */
}
and so on.

I think this is more flexible than having static member colors because it also allows member group to have custom fonts or basically anything that can be done via CSS.
    
Re: minor things
 August 03, 2012, 09:14:54 View in topic context
 Posted by Nightwish  in minor things (Started by Valodim July 27, 2012, 11:26:30
 Board: EosAlpha Bulletin Board System - development

Ok it looks like I'll have to do an alternate colorscheme over there, people apparently don't appreciate the professional style too much. And the have a point, it's a gaming forum, it shouldn't look "sterile". I still like the professional thing and the brighter colors were fine, don't let those guys influence you too much for your own design.
Nah, I'm not going to change this style much, just adding a couple of things like alternating row classes and such. The basic color scheme will stay.
Quote
The "merge post with last one" option doesn't show up in my place, and I couldn't find an option for that. I'm probably just missing it?
This is a "per board" option, you'll find it when creating or modifying a board.[/quote]
Quote
Oh one more thing, inline-modifying and quick-replying should be mutually exclusive in thread view, and when modifying it would be neat if the quote button added quotes inline.
Yup, there should be some locking.

BTW: there is now a way to easily override css. In theme_support.php, you can define a css file name (one per theme variant), put that file in the theme's css folder and it will be loaded *after* the main style sheet.
    
Re: minor things
 August 02, 2012, 13:55:41 View in topic context
 Posted by Nightwish  in minor things (Started by Valodim July 27, 2012, 11:26:30
 Board: EosAlpha Bulletin Board System - development

yeah. I'm using vim to edit files which always adds a \n to the end. and that usually makes sense, too, if not for php's quirky behavior :P
Killing all end tags should solve this problems...

Funny to read that Zend's official recommendations *forbids* end tags in files that only contain code and are not supposed to output anything (like most of our stuff in Sources/).

I still believe that this is a major bug (or design flaw) in php itself.
    
Re: minor things
 August 02, 2012, 12:54:21 View in topic context
 Posted by Nightwish  in minor things (Started by Valodim July 27, 2012, 11:26:30
 Board: EosAlpha Bulletin Board System - development

I see you're working on the white and font complaints. ;) Reply textarea is monospace right now?
It should be consolas (if available), monospace otherwise.

BTW: I'm probably dropping the index_default.css and make index_lightweight.css the new default. Looks better anyway...

BTW2: Seems like many xml responses are broken over there (topic preview, member cards and such) and it's now throwing js errors (timeOffsetMember). base.tpl was changed a bit and needs to be updated in the custom skin.

Also, I'm going to remove all closing tags in php source files - that's what is recommended anyway by Zend, because empty lines after closing tags can disturb xml reponses (if an xml response doesn't start with <?xml in the very first line, it's invalid). That's probably the source of the problems with topic previews...