YesNoOk
  1. Welcome!
    EosAlpha BBS is a fork of the popular Simple Machines Forum software. We aim at creating a new forum software, adding several new features and a modern and fresh design on top of the existing SMF code base.

    This software is currently in an early stage of development and this forum acts primarily as a testing platform for the ongoing development.

    Feel free to look around to get an idea about how it feels and looks.
avatar

Bug minor things (Read 15871 times)

Started by Valodim, July 27, 2012, 11:26:30

0 Members and 1 Guest are viewing this.
Share this topic:
#1
minor things |
July 27, 2012, 11:26:30
I tend to find very minor things here and there lately, making this topic so I have some place to note them down and not just forget them later.

Right now I only got the forum search, which says "search in this topic only" in the messagindex.

I'm also getting undefineds from the sidebar template regarding openid. did you drop openid? grep gives a lot of leftovers in the sources.

     Posted: July 27, 2012, 11:51:41
there is an onHover thing in topic_js.js which sets opacity = 1.0 on mouseover in the buttos bar but nothing else. that kinda thing should be done in the css as .post_bottom:hover.

     Posted: July 27, 2012, 11:58:17
the "Unapprove" icon is shown for moderators even when post moderation is disabled

     Posted: July 27, 2012, 13:16:41
http://forum.miranda.or.at/Themes/default/images/collapse.gif
http://forum.miranda.or.at/Themes/default/images/expand.gif

both missing on http://forum.miranda.or.at/stats
#2
Re: minor things |
July 30, 2012, 08:11:44
Regarding onHover, I haven't seen the code (I try to keep my hands off any other fork really ;), a question of principle until Wedge is out at least), but I'd venture into saying that it's Nightwish's way of providing support for IE6, because it only supports :hover on anchor tags.

An alternative way of doing it, and that's how I'm doing it in Wedge, is including an external script to support :hover on any tag. The one I'm using, and it's working nicely, is written by Gilmore Davidson and released under the MIT license.
__
  Wedge
« Everyone knows rock attained perfection in 1974.
It's a scientific fact. » (Homer Simpson)
#3
Re: minor things |
July 30, 2012, 08:17:09
Regarding onHover, I haven't seen the code (I try to keep my hands off any other fork really ;), a question of principle until Wedge is out at least), but I'd venture into saying that it's Nightwish's way of providing support for IE6, because it only supports :hover on anchor tags.
Good point if I were actually supporting IE6, which I don't :)

Honestly, cannot remember why I did this with JavaScript, there probably is (or was) a reason, but the reason does no longer exist. Most likely, this particular code fragment was just forgotten.

__
Every program has at least one bug and can be shortened by at least one instruction -- from which, by induction, one can deduce that every program can be reduced to a single instruction that doesn't work.
My SMF-based forum fork
#4
Re: minor things |
July 31, 2012, 01:48:47
The "when possible, merge..." text should be a <label> so when you click it the checkbox is toggled.

     Posted: July 31, 2012, 12:32:57
posts have no min-height attribute, which makes one-line posts have a bad post-to-signature ratio

     Posted: August 01, 2012, 23:38:20
2012-08-02 01:27:46: (mod_fastcgi.c.2701) FastCGI-stderr: PHP Fatal error:  require_once(): Failed opening required '/var/www/mugenguild.com/forum/Sources/Subs-Compat.php' (include_path='.:/usr/share/php:/usr/share/pear') in /var/www/mugenguild.com/forum/Sources/LogInOut.php on line 346

you missed a spot there

     Posted: August 01, 2012, 23:43:48
pretty urls only work if the separating character is -, if it's _ (which was the default for me) the topic id will still be delimited by a - which won't be recognized

     Posted: August 01, 2012, 23:45:26
btw don't mind my members too much, they can be a mean bunch and they're used to the theme we had for half a decade ;)
#5
Re: minor things |
August 02, 2012, 05:29:57
btw don't mind my members too much, they can be a mean bunch and they're used to the theme we had for half a decade ;)
Change is not always welcome, especially when the look changes so drastically. Remember the various sh1tstorms when big sites like google, youtube or facebook made changes :)

Not that bad, they seem to like most things and only complain about the theme being "too white" (which I pretty much expected anyway).
__
Every program has at least one bug and can be shortened by at least one instruction -- from which, by induction, one can deduce that every program can be reduced to a single instruction that doesn't work.
My SMF-based forum fork
#6
Re: minor things |
August 02, 2012, 12:32:17
I see you're working on the white and font complaints. ;) Reply textarea is monospace right now?
#7
Re: minor things |
August 02, 2012, 12:54:21
I see you're working on the white and font complaints. ;) Reply textarea is monospace right now?
It should be consolas (if available), monospace otherwise.

BTW: I'm probably dropping the index_default.css and make index_lightweight.css the new default. Looks better anyway...

BTW2: Seems like many xml responses are broken over there (topic preview, member cards and such) and it's now throwing js errors (timeOffsetMember). base.tpl was changed a bit and needs to be updated in the custom skin.

Also, I'm going to remove all closing tags in php source files - that's what is recommended anyway by Zend, because empty lines after closing tags can disturb xml reponses (if an xml response doesn't start with <?xml in the very first line, it's invalid). That's probably the source of the problems with topic previews...
__
Every program has at least one bug and can be shortened by at least one instruction -- from which, by induction, one can deduce that every program can be reduced to a single instruction that doesn't work.
My SMF-based forum fork
#8
Re: minor things |
August 02, 2012, 13:43:16
yeah. I'm using vim to edit files which always adds a \n to the end. and that usually makes sense, too, if not for php's quirky behavior :P

     Posted: August 02, 2012, 13:53:29
monospace in post editor but non-monospace in regular post view is a bad idea, because people will align things or do tables

like this
       ^

or put code and expect it to look ok in the post as well
#9
Re: minor things |
August 02, 2012, 13:55:41
yeah. I'm using vim to edit files which always adds a \n to the end. and that usually makes sense, too, if not for php's quirky behavior :P
Killing all end tags should solve this problems...

Funny to read that Zend's official recommendations *forbids* end tags in files that only contain code and are not supposed to output anything (like most of our stuff in Sources/).

I still believe that this is a major bug (or design flaw) in php itself.
__
Every program has at least one bug and can be shortened by at least one instruction -- from which, by induction, one can deduce that every program can be reduced to a single instruction that doesn't work.
My SMF-based forum fork
#10
Re: minor things |
August 03, 2012, 00:19:41
Ok it looks like I'll have to do an alternate colorscheme over there, people apparently don't appreciate the professional style too much. And the have a point, it's a gaming forum, it shouldn't look "sterile". I still like the professional thing and the brighter colors were fine, don't let those guys influence you too much for your own design.

The "merge post with last one" option doesn't show up in my place, and I couldn't find an option for that. I'm probably just missing it?

Oh one more thing, inline-modifying and quick-replying should be mutually exclusive in thread view, and when modifying it would be neat if the quote button added quotes inline.
#11
Re: minor things |
August 03, 2012, 09:14:54
Ok it looks like I'll have to do an alternate colorscheme over there, people apparently don't appreciate the professional style too much. And the have a point, it's a gaming forum, it shouldn't look "sterile". I still like the professional thing and the brighter colors were fine, don't let those guys influence you too much for your own design.
Nah, I'm not going to change this style much, just adding a couple of things like alternating row classes and such. The basic color scheme will stay.
Quote
The "merge post with last one" option doesn't show up in my place, and I couldn't find an option for that. I'm probably just missing it?
This is a "per board" option, you'll find it when creating or modifying a board.[/quote]
Quote
Oh one more thing, inline-modifying and quick-replying should be mutually exclusive in thread view, and when modifying it would be neat if the quote button added quotes inline.
Yup, there should be some locking.

BTW: there is now a way to easily override css. In theme_support.php, you can define a css file name (one per theme variant), put that file in the theme's css folder and it will be loaded *after* the main style sheet.
__
Every program has at least one bug and can be shortened by at least one instruction -- from which, by induction, one can deduce that every program can be reduced to a single instruction that doesn't work.
My SMF-based forum fork
#12
Re: minor things |
August 04, 2012, 11:58:16
you probably already noticed, but you used "on" instead of "bind" in bbc_refresh, which breaks spoilers and other things :)

Quote
BTW: there is now a way to easily override css. In theme_support.php, you can define a css file name (one per theme variant), put that file in the theme's css folder and it will be loaded *after* the main style sheet.

yeah I hope to get there some time, right now I need a couple of template changes as well. ah well, diff-updating is fairly painless at this point :)

     Posted: August 04, 2012, 12:14:44
fetch a preview when user clicks "go advanced"?
#13
Re: minor things |
August 04, 2012, 12:33:45
you probably already noticed, but you used "on" instead of "bind" in bbc_refresh, which breaks spoilers and other things :)
Ups... because the bundled jQuery is still an older one. You can enable the option to load jQuery from Google's CDN which has already been told to fetch 1.7.2. It will also save you some traffic :)

The bundled was still at 1.6, probably forgot to update it.
Quote
Quote
BTW: there is now a way to easily override css. In theme_support.php, you can define a css file name (one per theme variant), put that file in the theme's css folder and it will be loaded *after* the main style sheet.

yeah I hope to get there some time, right now I need a couple of template changes as well. ah well, diff-updating is fairly painless at this point :)
You could use template overrides (should already work).. See Themes/default/tpl/overrides/readme, so in theory, you could simply use the default theme and customize it via css- and template overrides. Depending on the scale of template changes, merging could still be a pain, I know.

Also, some heads up because of this, though it should not break things. Unless you explicitly enable this in Membergroups->Settings, it will dynamically build an inline style sheet using the old colors.
__
Every program has at least one bug and can be shortened by at least one instruction -- from which, by induction, one can deduce that every program can be reduced to a single instruction that doesn't work.
My SMF-based forum fork
#14
Re: minor things |
August 04, 2012, 13:02:01
it would, if the styles were set as "a.member .group_1" instead of "a.member group_1" ;)
actually it doesn't that way either :P
 

      Posted: August 04, 2012, 13:02:58
oh and I already use template overrides, that works just fine
Last Edit: August 04, 2012, 13:12:14 by Valodim
#15
Re: minor things |
August 04, 2012, 14:11:26
it would, if the styles were set as "a.member .group_1" instead of "a.member group_1" ;)
actually it doesn't that way either :P
The inline styles are regenerated when you modify a member group in the admin panel (for a fresh install, they would be pre-populated in the db).

(Yes, I know, a updater script would be awesome :) )
__
Every program has at least one bug and can be shortened by at least one instruction -- from which, by induction, one can deduce that every program can be reduced to a single instruction that doesn't work.
My SMF-based forum fork
#16
Re: minor things |
August 04, 2012, 14:17:28
suggestion for short user agent: shorten_subject(substr($url['USER_AGENT'], 0, strpos($url['USER_AGENT'], ' ')), 25) that will shorten to something like "Mozilla/5.0" or "Opera/9.8"

About the group colors, I actually meant that the css identifier is wrong, it targets the element group_1 instead of class .group_1

     Posted: August 04, 2012, 14:33:01
here's a bit for your wiki, I just used the second query to convert the msn profile field. first is just for reference.

Code:
INSERT INTO `yabbse_custom_fields` (`col_name`, `field_name`, `field_desc`, `field_type`, `field_length`, `field_options`, `mask`, `show_reg`, `show_display`, `show_profile`, `private`, `active`, `bbc`, `can_search`, `default_value`, `enclose`, `placement`) VALUES ('cust_msn','MSN','MSN Messenger address','text',255,'','email',0,1,'forumprofile',0,1,0,1,'','<a href=\"msnim:chat?contact={INPUT}\"><img src=\"{IMAGES_URL}/msn.png\" alt=\"{INPUT}\" /></a>',1);

REPLACE INTO yabbse_themes (id_member, id_theme, variable, value) SELECT id_member, 1, 'cust_msn', msn FROM yabbse_members WHERE msn IS NOT NULL AND msn LIKE '%@%' ;
#17
Re: minor things |
August 04, 2012, 14:52:03
suggestion for short user agent: shorten_subject(substr($url['USER_AGENT'], 0, strpos($url['USER_AGENT'], ' ')), 25) that will shorten to something like "Mozilla/5.0" or "Opera/9.8"
Done (and when you click on the shortened version, you see the full one).
Quote
About the group colors, I actually meant that the css identifier is wrong, it targets the element group_1 instead of class .group_1
Will be in the next commit.
Quote
here's a bit for your wiki, I just used the second query to convert the msn profile field. first is just for reference.
Thanks. Guess that would also work for the other removed profile fields...
__
Every program has at least one bug and can be shortened by at least one instruction -- from which, by induction, one can deduce that every program can be reduced to a single instruction that doesn't work.
My SMF-based forum fork
#18
Re: minor things |
August 05, 2012, 00:56:40
love the "new" indicator.

huge timestamps right now with GMT+2 stuff, probably just a temporary state during development~

do you have plans to show more events in a user's activity stream? most significantly, topic reply notifications?
#19
Re: minor things |
August 05, 2012, 01:07:25
huge timestamps right now with GMT+2 stuff, probably just a temporary state during development~
Screenshots, browser version?
It's now using toLocaleTimeString() method and I'm seeing normal timestamps over there...
Quote
do you have plans to show more events in a user's activity stream? most significantly, topic reply notifications?
Yup, activity stream can be used for all kind of things, you already can get notifications when someone posts a reply (but by default, this kind of notification is disabled). Also, members can opt-out from creating activities (I think, that's a privacy thing and should be allowed).

More interesting would be a 'your message has been quoted' notification...

BTW: There is one important fix in one of the last commits to load theme_support.php from the default theme if the custom theme doesn't have one.

And I still get xml responses with empty lines at the beginning - weird, ob_sessrewrite() now does a ltrim() on the buffer - have tested it here on my server and it works, at least when I deliberately insert blank lines in the xml templates.
__
Every program has at least one bug and can be shortened by at least one instruction -- from which, by induction, one can deduce that every program can be reduced to a single instruction that doesn't work.
My SMF-based forum fork
#20
Re: minor things |
August 05, 2012, 09:17:22
I use luakit so it's libwebkit rendering, here's a shot.

the newline thing got me stumped as well :\

     Posted: August 05, 2012, 10:57:49
the pm layout gets really cramped at 1024 pixels width, which is a resolution that should still be supported. maybe put the messages on the full screen width below the menu and pm list?

I didn't give it a shot yet because the change is non-trivial with how the template is stacked right now (and it's going to be converted soon anyways I guess)
#21
Re: minor things |
August 05, 2012, 11:48:38
I use luakit so it's libwebkit rendering, here's a shot.
What I expected - it's browser specific what toLocaleTimeString() returns. Guess, I've to find another way to get a locale-aware time format (not so easy in JavaScript).

      Posted: August 05, 2012, 10:57:49
Quote
the pm layout gets really cramped at 1024 pixels width, which is a resolution that should still be supported. maybe put the messages on the full screen width below the menu and pm list?

I didn't give it a shot yet because the change is non-trivial with how the template is stacked right now (and it's going to be converted soon anyways I guess)
PMs will just get a different postbit layout anyway (one without a wide left column, because it's the left column that eats too much space.

BTW: This fix in Load.php is important to avoid tons of warnings about undefined in the log when using a custom theme.

     Posted: August 05, 2012, 14:06:50
Ok...

New time formatting code should be in here...

It should now recognize the member's PHP-style time format (set in the profile) and output either 24hr or 12hr AM/PM time stamps without seconds or time zone information.
__
Every program has at least one bug and can be shortened by at least one instruction -- from which, by induction, one can deduce that every program can be reduced to a single instruction that doesn't work.
My SMF-based forum fork
#22
Re: minor things |
August 05, 2012, 14:11:59
yup, looks good now. nice work.

     Posted: August 05, 2012, 16:20:44
found the cause for the broken preview - my report borad modification added an empty line after the ?> in Error.english.php :)

also, for the record, php ignores a newline after ?> at the end of files automagically. that's not really consistent behavior, but it allowed xml to work even when there were all those ?>s around

the description for merging of posts in the admin panel is wrong: it says the number of minutes determines the maximum age of the last post for the merge. in the implementation, it's actually the maximum age for the last post to perform merging whether the user checked the box or not. both ways make sense I guess, but they should be coherent ;)
#23
Re: minor things |
August 05, 2012, 16:34:30
found the cause for the broken preview - my report borad modification added an empty line after the ?> in Error.english.php :)
also, for the record, php ignores a newline after ?> at the end of files automagically. that's not really consistent behavior, but it allowed xml to work even when there were all those ?>s around
For some reason, it doesn't always work - sometimes, the new lines sneak into the output and ruin xml responses. This is a mess and the worst thing is that these empty lines sneak in before the output buffer is sent, so trimming the buffer doesn't help either.
Quote
the description for merging of posts in the admin panel is wrong: it says the number of minutes determines the maximum age of the last post for the merge. in the implementation, it's actually the maximum age for the last post to perform merging whether the user checked the box or not. both ways make sense I guess, but they should be coherent ;)
There should be a permission to prevent users from un-checking the merge box and force them into merging.

BTW:

https:/..../forum/Themes/mfg/css/index_lightweight.css?v=1572

returns 404?

mfg theme broken for me...
__
Every program has at least one bug and can be shortened by at least one instruction -- from which, by induction, one can deduce that every program can be reduced to a single instruction that doesn't work.
My SMF-based forum fork
#24
Re: minor things |
August 05, 2012, 16:43:30
eh, that one is laziness on my part, I basically did mv index_lightweight.css index_default.css to make lightweight the default (and only) variant :P
Last Edit: August 06, 2012, 22:08:15 by Valodim
#25
Re: minor things |
August 06, 2012, 22:08:08
PersonalMessages.php line 710, that one is a huge bug because notifications link to pms which are not the head of a conversation. Also, why shouldn't a user be allowed to see a conversation if the selected pm is not the head of it?