YesNoOk

Recent Posts

    
Re: Wiki is up
 July 30, 2012, 23:50:54 View in topic context
#91
avatar  Posted by Valodim  in Wiki is up (Started by Nightwish July 30, 2012, 05:27:09
 Board: EosAlpha Bulletin Board System - development

here's what I'm using with lighty for url-rewriting, that bit seems to be missing at the prettyurls page:

Code:
    url.rewrite-if-not-file += (
      "^/forum/([^?]*)$" => "/forum/index.php?q=$1",
    )

it simply rewrites anything that doesn't exist and has no ? in it.
    
Re: minor things
 July 30, 2012, 08:17:09 View in topic context
#92
 Posted by Nightwish  in minor things (Started by Valodim July 27, 2012, 11:26:30
 Board: EosAlpha Bulletin Board System - development

Regarding onHover, I haven't seen the code (I try to keep my hands off any other fork really ;), a question of principle until Wedge is out at least), but I'd venture into saying that it's Nightwish's way of providing support for IE6, because it only supports :hover on anchor tags.
Good point if I were actually supporting IE6, which I don't :)

Honestly, cannot remember why I did this with JavaScript, there probably is (or was) a reason, but the reason does no longer exist. Most likely, this particular code fragment was just forgotten.

    
Re: ipv6
 July 30, 2012, 08:16:02 View in topic context
#93
 Posted by Nao  in ipv6 (Started by Valodim July 22, 2012, 20:20:42
 Board: EosAlpha Bulletin Board System - development

Arantor wrote support for IPv6 into Wedge about a year ago. We have yet to see any issues with it.
Since Wedge will be MPL'ed, I'd suggest as an alternative to: revert this commit, wait for Wedge alpha to be out, and take our working IPv6 code. (It would also be a good opportunity to switch EosAlpha to MPL, which I find is a more solid permissive license than BSD/MIT for 'obscure' projects like both Wedge and EosAlpha.)
    
Re: minor things
 July 30, 2012, 08:11:44 View in topic context
#94
 Posted by Nao  in minor things (Started by Valodim July 27, 2012, 11:26:30
 Board: EosAlpha Bulletin Board System - development

Regarding onHover, I haven't seen the code (I try to keep my hands off any other fork really ;), a question of principle until Wedge is out at least), but I'd venture into saying that it's Nightwish's way of providing support for IE6, because it only supports :hover on anchor tags.

An alternative way of doing it, and that's how I'm doing it in Wedge, is including an external script to support :hover on any tag. The one I'm using, and it's working nicely, is written by Gilmore Davidson and released under the MIT license.
    
Wiki is up
 July 30, 2012, 05:27:09 View in topic context
#95
 Posted by Nightwish  in Wiki is up (Started by Nightwish July 30, 2012, 05:27:09
 Board: EosAlpha Bulletin Board System - development

To make documentation easier, I've decided to open up a Wiki., based on pmWiki which is ideal for smaller projects.

Right now, it barely has any content and there isn't much to see (except the cool theme :) ), but I believe a Wiki is a better way to document things than having everything buried deeply in forum threads.
    
minor things
 July 27, 2012, 11:26:30 View in topic context
#96
avatar  Posted by Valodim  in minor things (Started by Valodim July 27, 2012, 11:26:30
 Board: EosAlpha Bulletin Board System - development

I tend to find very minor things here and there lately, making this topic so I have some place to note them down and not just forget them later.

Right now I only got the forum search, which says "search in this topic only" in the messagindex.

I'm also getting undefineds from the sidebar template regarding openid. did you drop openid? grep gives a lot of leftovers in the sources.

     Posted: July 27, 2012, 11:51:41
there is an onHover thing in topic_js.js which sets opacity = 1.0 on mouseover in the buttos bar but nothing else. that kinda thing should be done in the css as .post_bottom:hover.

     Posted: July 27, 2012, 11:58:17
the "Unapprove" icon is shown for moderators even when post moderation is disabled

     Posted: July 27, 2012, 13:16:41
http://forum.miranda.or.at/Themes/default/images/collapse.gif
http://forum.miranda.or.at/Themes/default/images/expand.gif

both missing on http://forum.miranda.or.at/stats
    
Re: Database changes
 July 27, 2012, 04:44:04 View in topic context
#97
 Posted by Nightwish  in Database changes (Started by Nightwish July 27, 2012, 01:05:13
 Board: Change logs

Commit 53a87994a49b58f4bd7f64f0bfd11e421a195cad, changes to the rating system requires changes to {db_prefix}likes.
Code: (mysql)
ALTER TABLE {db_prefix}likes MODIFY rtype VARCHAR(60) NOT NULL DEFAULT '1';
ALTER TABLE {db_prefix}likes ADD comment VARCHAR(255) NOT NULL DEFAULT '' AFTER rtype;
ALTER TABLE {db_prefix}likes ADD KEY rtype(rtype);
    
Database changes
 July 27, 2012, 01:05:13 View in topic context
#98
 Posted by Nightwish  in Database changes (Started by Nightwish July 27, 2012, 01:05:13
 Board: Change logs

This topic documents all database changes made:

All changes relative to a stock SMF 2.0 database structure are documented in table-changes.sql which can be found in the source repository.

Commit 105e4a625cd163e584b8903278254e0d7217ee0c - added IPv6 support (ported from SMF 2.1 development branch).

Changes made to table ban_items:
Code: (mysql)
#
# Table structure for table `ban_items`
#

CREATE TABLE {$db_prefix}ban_items (
  id_ban mediumint(8) unsigned NOT NULL auto_increment,
  id_ban_group smallint(5) unsigned NOT NULL default '0',
  ip_low1 smallint(255) unsigned NOT NULL default '0',
  ip_high1 smallint(255) unsigned NOT NULL default '0',
  ip_low2 smallint(255) unsigned NOT NULL default '0',
  ip_high2 smallint(255) unsigned NOT NULL default '0',
  ip_low3 smallint(255) unsigned NOT NULL default '0',
  ip_high3 smallint(255) unsigned NOT NULL default '0',
  ip_low4 smallint(255) unsigned NOT NULL default '0',
  ip_high4 smallint(255) unsigned NOT NULL default '0',
  ip_low5 smallint(255) unsigned NOT NULL default '0',
  ip_high5 smallint(255) unsigned NOT NULL default '0',
  ip_low6 smallint(255) unsigned NOT NULL default '0',
  ip_high6 smallint(255) unsigned NOT NULL default '0',
  ip_low7 smallint(255) unsigned NOT NULL default '0',
  ip_high7 smallint(255) unsigned NOT NULL default '0',
  ip_low8 smallint(255) unsigned NOT NULL default '0',
  ip_high8 smallint(255) unsigned NOT NULL default '0',
  hostname varchar(255) NOT NULL default '',
  email_address varchar(255) NOT NULL default '',
  id_member mediumint(8) unsigned NOT NULL default '0',
  hits mediumint(8) unsigned NOT NULL default '0',
  PRIMARY KEY (id_ban),
  KEY id_ban_group (id_ban_group)
) ENGINE=MyISAM;
    
Re: Re: Syntaxhighlighter test
 July 26, 2012, 22:28:41 View in topic context
#99
 Posted by Nightwish  in Re: Syntaxhighlighter test (Started by Nightwish September 19, 2011, 03:47:31
 Board: Showcase

Is this information still up to date? Or have you changed to prettify.js?
It is prettify now
Quote
on a related note, drafts.js is still referenced from Post.php and Display.php, but you removed it in an earlier commit.
Drafts feature will most likely be a plugin, right now it's still a core feature, so parts of the code are still left in the core.
    
Re: Re: Syntaxhighlighter test
 July 26, 2012, 18:17:20 View in topic context
#100
avatar  Posted by Valodim  in Re: Syntaxhighlighter test (Started by Nightwish September 19, 2011, 03:47:31
 Board: Showcase

Is this information still up to date? Or have you changed to prettify.js?

on a related note, drafts.js is still referenced from Post.php and Display.php, but you removed it in an earlier commit.
    
Re: Plugins
 July 26, 2012, 06:38:38 View in topic context
#101
 Posted by Nightwish  in Plugins (Started by Nightwish July 15, 2012, 14:58:44
 Board: Showcase

There should be more feedback in the installation procedure, perhaps an array_diff output showing how hooks changed or something, although all of that is probably in the pipeline already ;)
Hook installation will probably be logged in some way. Errors like duplicate hooks or non-existing files/callables are already logged to the error log, but on success, nothing happens (yet).

Also, if an error occurs during hook installation, the entire plugin should be deactivated to avoid more serious problems. That's also planned. Right now, it is possible to end up with a partial plugin installation, which is bad.

There is also a (currently inoperative) hooks tab which will allow to browse hooks by plugin, by hook type and so on..
    
Re: Plugins
 July 26, 2012, 00:43:02 View in topic context
#102
avatar  Posted by Valodim  in Plugins (Started by Nightwish July 15, 2012, 14:58:44
 Board: Showcase

Got it.

addHook() used updateSettings($change_array, true); which uses an UPDATE query instead of REPLACE INTO - which doesn't work if integration_hooks isn't already present. Maybe use updateSettings($change_array, false) there, performance is certainly not an issue for hook installation :)

There should be more feedback in the installation procedure, perhaps an array_diff output showing how hooks changed or something, although all of that is probably in the pipeline already ;)
    
Re: Plugins
 July 25, 2012, 21:50:22 View in topic context
#103
 Posted by Nightwish  in Plugins (Started by Nightwish July 15, 2012, 14:58:44
 Board: Showcase

Should this feature work, yet? I wrote a plugin and activated it, so far so good, but it was never called, and when I looked for it I couldn't find any code that would load a plugin outside the plugin admin area. Am I doing something wrong, or is this still a work in progress?
It should work (I already have a few simple plugins working, like the github feed block in the side bar).

Plugins must use hooks to execute code, so it's a matter of choosing the proper hook to inject your code into (and yes, I know, there are way too few hooks at the moment, making some more advanced plugins impossible).

Look at addons/gitfeed/main.php for a very simple plugin.
    
Re: Plugins
 July 25, 2012, 20:40:44 View in topic context
#104
avatar  Posted by Valodim  in Plugins (Started by Nightwish July 15, 2012, 14:58:44
 Board: Showcase

Should this feature work, yet? I wrote a plugin and activated it, so far so good, but it was never called, and when I looked for it I couldn't find any code that would load a plugin outside the plugin admin area. Am I doing something wrong, or is this still a work in progress?
    
Re: ipv6
 July 23, 2012, 18:30:31 View in topic context
#105
avatar  Posted by Valodim  in ipv6 (Started by Valodim July 22, 2012, 20:20:42
 Board: EosAlpha Bulletin Board System - development

getting fatal error call to undefined function constructBanQueryIP on this site. check Security.php line 251. that line is never executed if($user_info['is_admin']) ;)
1 Useful