YesNoOk
  1. Welcome!
    EosAlpha BBS is a fork of the popular Simple Machines Forum software. We aim at creating a new forum software, adding several new features and a modern and fresh design on top of the existing SMF code base.

    This software is currently in an early stage of development and this forum acts primarily as a testing platform for the ongoing development.

    Feel free to look around to get an idea about how it feels and looks.
avatar

Bug minor things (Read 17482 times)

Started by Valodim, July 27, 2012, 11:26:30

0 Members and 1 Guest are viewing this.
Share this topic:
#26
Re: minor things |
August 06, 2012, 22:17:24
PersonalMessages.php line 710, that one is a huge bug because notifications link to pms which are not the head of a conversation. Also, why shouldn't a user be allowed to see a conversation if the selected pm is not the head of it?
Need to investigate this, there might very well be a good reason for this code. This code is in SMF 2.0 and 2.1 (development branch) as well, but I can see how it conflicts with the notifications.
__
Every program has at least one bug and can be shortened by at least one instruction -- from which, by induction, one can deduce that every program can be reduced to a single instruction that doesn't work.
My SMF-based forum fork
#27
Re: minor things |
August 06, 2012, 22:42:40
The query above it looks fine to me. It does a GROUP BY pm.id_pm_head and only selects this id_pm_head and the MAX(pm.id_pm), which means it is not relevant which pm is selected out of all which have the same id_pm_head.

The INNER JOIN also has a check for the correct member id no matter what, so it's not possible to get other users' pms in there.

I don't think that check is necessary.

      Posted: August 06, 2012, 23:25:36
the facebook like button should not require an app id anymore since version 1.2, an url should be sufficient.
Last Edit: August 06, 2012, 23:26:04 by Valodim
#28
Re: minor things |
August 07, 2012, 08:30:48
I don't think that check is necessary.
Still not 100% sure, but you're probably right. I tried to break in with all kind of scary pm requests - no success even with admin privileges. What bothers me a bit is that this code was explicitly written for the conversation view, so it's not a leftover from old code.

About today's commit(s): Lots of stuff again, mostly in the pm system. Template conversion goes fine and there are only 2 really big ones left - the profile stuff and the post.template (+a couple of smaller ones).

You may want to take care when merging Subs-Editor.php because of the new buttons.


     Posted: August 10, 2012, 18:36:33
Some heads for upcoming changes...

I've started splitting (and somewhat cleaning up) the main style sheets. To make things easier for theme designers, the main css will be split into two files:
  • base.css - contains only layout-related things, like margins, positions, list layouts and similar.
  • skin_themevariantname.css - contains all the fonts, colors, gradients, images and such.
The base.css is loaded first, so the skin stylesheet can override things in the base if needed. This should it make easier to create color variants without affecting the layout too much and will support the concept of theme variants (as defined in theme_support.php) which act as sub-styles of the current theme.

Basically, you could leave everything in base.css and create a empty skin_default.css (or do it vice versa and keep everything in skin_default.css and create an empty base.css), if you have already customized the css too much.

Other things implemented
  • Auto-sizing textareas for quick reply and inline-modify. It will initially start small and automatically expand or shrink wile typing a message.
  • New profile option for setting the initial size of the full post editor that replaces the stupid resizing bar which didn't work on all browsers and did not remember its setting.

This stuff should be committed later this day (or maybe on the weekend).
__
Every program has at least one bug and can be shortened by at least one instruction -- from which, by induction, one can deduce that every program can be reduced to a single instruction that doesn't work.
My SMF-based forum fork
1 Useful 
Last Edit: August 10, 2012, 18:36:33 by Nightwish
#29
Re: minor things |
August 11, 2012, 21:17:01
fyi: not slacking off, but I need to prepare a presentation for uni for monday that's why I'm MIA right now.

Restructuring the stylesheets is a great idea. While you're doing that, have you ever looked at SASS? Whole new dimension of stylesheets :)

     Posted: August 11, 2012, 21:43:24
quickreply and edit should have a bigger min-height
#30
Re: minor things |
August 11, 2012, 23:57:28
fyi: not slacking off, but I need to prepare a presentation for uni for monday that's why I'm MIA right now.
Yeah, have read it over there...
Quote
Restructuring the stylesheets is a great idea. While you're doing that, have you ever looked at SASS? Whole new dimension of stylesheets :)
Yup and I *might* be using that at some point, just not now.
Quote
quickreply and edit should have a bigger min-height
They should now auto-expand (and shrink) as needed and only start with a small height (if not, force-reloading might help, you may still have the old scripts in the cache).
__
Every program has at least one bug and can be shortened by at least one instruction -- from which, by induction, one can deduce that every program can be reduced to a single instruction that doesn't work.
My SMF-based forum fork
#31
Re: minor things |
August 17, 2012, 11:26:58
alright, I cleaned up my css and all changes are now in an overriding css file while leaving the others untouched. much better now. also incorporated color changes by popular demand :P

Still in the process of cleaning up my working tree and moving mods into plugins. That really is a lot cleaner than the direct software hacks :)
#32
Re: minor things |
August 17, 2012, 13:37:21
Ok fine...

Just some notes about the changes from the last couple of days. Nothing ground-breaking, just template stuff mainly. PM templates are done, profile templates about 90% done.

Plans for the near future: finish the template stuff, then get the mobile theme into a usable state (the first version will probably be very basic and bare-bone, supporting only the most important pages - board index, message index and topic display).

     Posted: August 18, 2012, 17:19:43
About today's commit:

Make sure Profile.template.php does NOT get removed from Themes/default as it's still needed in Register(). I already moved it to Deprecated/, but this was in error. The last commit should revert this anyway, just to make sure...
__
Every program has at least one bug and can be shortened by at least one instruction -- from which, by induction, one can deduce that every program can be reduced to a single instruction that doesn't work.
My SMF-based forum fork
#33
Re: minor things |
August 19, 2012, 16:43:36
Today, I've added SphinxQL SearchAPI support. This commit shouldn't conflict with anything search-related, but some testing is needed before I can deprecate the old Sphinx search support which is really no longer needed, because SphinxQL was implemented around version 1.0 quite some time ago.

SphinxQL should improve search performance even further and also fix the bugs with some result sorting methods not being available with the old Sphinx API.

SphinxQL requires a minimal change to the existing sphinx.conf. The port for incoming SphinxQL queries must be specified and must be different from the standard port.
Code: (text)
searchd
{
        listen = 3312
        listen = 3313:mysql41   << this one
        log = /var/sphinx/log/searchd.log
        query_log = /var/sphinx/log/query.log
        read_timeout = 5
        max_children = 30
        pid_file = /var/sphinx/data/searchd.pid
        max_matches = 1000
}

Sphinx settings were overhauled as well, all strings should now be translatable and the "Test connection" button should also perform a test for SphinxQL connections.
__
Every program has at least one bug and can be shortened by at least one instruction -- from which, by induction, one can deduce that every program can be reduced to a single instruction that doesn't work.
My SMF-based forum fork
#34
Re: minor things |
August 24, 2012, 19:07:23
sadly, I can't update my sphinxsearch. it requires a newer libc, which is a showstopper :(

     Posted: August 24, 2012, 22:01:42
the sphinx guys had a package with a newer version, but compiled for older ubuntu! all working now, yay :)
#35
Re: minor things |
August 25, 2012, 13:25:42
Problem with entering text in Cyrillic - for exapmle when i try to add Topic prefix or Post ratings. In Latin letters are okay
#36
Re: minor things |
August 26, 2012, 13:49:31
Problem with entering text in Cyrillic - for exapmle when i try to add Topic prefix or Post ratings. In Latin letters are okay
Should be fixed with the last commit from today, but please note that the admin UI for both features (topic prefixes and ratings) is very basic at the moment and some features are missing.
__
Every program has at least one bug and can be shortened by at least one instruction -- from which, by induction, one can deduce that every program can be reduced to a single instruction that doesn't work.
My SMF-based forum fork
#37
Re: minor things |
August 30, 2012, 18:51:10
Incoming changes:
  • Some styling changes in the default theme (there is now only one theme_variant - default).
  • Topic bans. Moderators can now ban members from specific topics only without changing their permissions. A member who has been banned from a topic can not participate in it (no post/reply/modify), but can still read it normally. Topic bans can expire automatically after x days (done in daily maintenance) or be permanent until lifted by a moderator. A member who has been banned from a topic will see a notice explaining it.

    Right now, the UI is sparse - moderators will see a new button next to the warning/report button in the bottom left corner of a post. This will lead to the moderation center where a ban can be set or a existing ban can be lifted.

    Viewing existing topic bans by topic or member will be added to the moderation center soon and the topic ban system will be integrated into the warning system allowing a moderator who can issue warnings to set a topic ban together with a warning.

    This requires a db scheme change with the new table topicbans.

Edit:

@Valodim: Does the SphinxQL work over there? Because if it does, I'm going to deprecate the old sphinx code soon. It's buggy anyway, throwing errors when using certain sorting methods and a bit slower than SphinxQL. Also, it's a bit confusing to have Sphinx twice in the search method administration UI.
__
Every program has at least one bug and can be shortened by at least one instruction -- from which, by induction, one can deduce that every program can be reduced to a single instruction that doesn't work.
My SMF-based forum fork
1 Like It 
Last Edit: August 30, 2012, 19:33:10 by Nightwish
#38
Re: minor things |
August 30, 2012, 23:57:49
Neat, topic bans. I know some mods will be happy about that :)

And yeah, SphinxQL works all fine :)

     Posted: August 31, 2012, 00:02:07
come to think of it, shouldn't something like a topic ban be fairly easy implementable as an addon?
#39
Re: minor things |
August 31, 2012, 01:26:47
And yeah, SphinxQL works all fine :)
Ok, then I can remove the old code soon.
Quote
come to think of it, shouldn't something like a topic ban be fairly easy implementable as an addon?
Maybe later. Right now, the mod system isn't able to perform db changes and such. Apart from this, it's not really difficult to convert it into a plugin (except for the warning system integration maybe).
__
Every program has at least one bug and can be shortened by at least one instruction -- from which, by induction, one can deduce that every program can be reduced to a single instruction that doesn't work.
My SMF-based forum fork
#40
Re: minor things |
September 22, 2012, 21:33:43
back from some absence (again)

In Profile-View.php in showPosts(), is the $range_limit yours? It seems to be a performance thing, but on my forum it hides huge numbers of posts for some members, in one extreme case all but two out of 1500. Ditched it for now.
#41
Re: minor things |
September 23, 2012, 14:52:27
back from some absence (again)

In Profile-View.php in showPosts(), is the $range_limit yours? It seems to be a performance thing, but on my forum it hides huge numbers of posts for some members, in one extreme case all but two out of 1500. Ditched it for now.
Hm, cannot remember implementing such a thing, so it's probably a SMF feature. I can vaguely remember a discussion about performance problems of the find content feature a while ago (during 2.0 development), so maybe that feature is just buggy. Will have to check this against current smf 2.1 code (which has most of the known 2.0 bugs already fixed).
__
Every program has at least one bug and can be shortened by at least one instruction -- from which, by induction, one can deduce that every program can be reduced to a single instruction that doesn't work.
My SMF-based forum fork
#42
Re: minor things |
September 23, 2012, 16:44:29
doesn't seem particularly slow to me even for members with huge amounts of posts. oh well.
#43
Re: minor things |
September 23, 2012, 23:08:19
doesn't seem particularly slow to me even for members with huge amounts of posts. oh well.
No, it's not slow. Checked the queries and they're all fine - no file sorts or other evil things. The range limit is strange, but it's definitely from SMF as it's still in the 2.1 code base in unmodified form.
__
Every program has at least one bug and can be shortened by at least one instruction -- from which, by induction, one can deduce that every program can be reduced to a single instruction that doesn't work.
My SMF-based forum fork
#44
Re: minor things |
September 25, 2012, 01:53:05
git blame -> contact the developer? or maybe just get rid of it :P
#45
Re: minor things |
September 28, 2012, 19:05:01
fyi, I'm in the process of doing a css rewrite using sass and compass of the default layout right now.

At this point, I'm simply porting the css into cleaner sass syntax without changing templates. But ultimately, I aim to have the entire html use exclusively semantic descriptions, shifting all layouting into the css. If I'm doing this right, at the end of this there should be no style attributes left besides ajax things like "display: none" or dynamic ones, and no layouting class names like "floatleft".

     Posted: September 29, 2012, 20:47:59
install.php:

Quote
Some of the queries were not executed properly. This could be caused by an unsupported (development or old) version of your database software.

Technical information about the queries:
Line #1966: Column count doesn't match value count at row 29
Line #2217: Incorrect table definition; there can be only one auto column and it must be defined as a key
#46
Re: minor things |
September 30, 2012, 14:38:04
fyi, I'm in the process of doing a css rewrite using sass and compass of the default layout right now.
At this point, I'm simply porting the css into cleaner sass syntax without changing templates. But ultimately, I aim to have the entire html use exclusively semantic descriptions, shifting all layouting into the css. If I'm doing this right, at the end of this there should be no style attributes left besides ajax things like "display: none" or dynamic ones, and no layouting class names like "floatleft".
All style attributes in the templates are just temporary hacks or leftovers from the old templates. The plan is to kill them anyway (except for the very few that are needed). Layouting classes like floatleft do make sense though, because they easily allow to make the theme RTL aware (not that the current theme is fully RTL compatible, but the basic idea still stands).

Quote
Some of the queries were not executed properly. This could be caused by an unsupported (development or old) version of your database software.
I'm surprised the installer doesn't throw more serious errors :) Install.php (and especially upgrade.php) are totally untested. The last test with install.php was a couple of months back, before some database changes were made.

FYI: I'm also pretty busy at the moment, so activity was a bit low in the last couple of days. It's just temporary :)

Additionally, this forum may be go down for a short while in the next couple of days, since the server will be deactivated at the end of october, I need to switch to a different host.
__
Every program has at least one bug and can be shortened by at least one instruction -- from which, by induction, one can deduce that every program can be reduced to a single instruction that doesn't work.
My SMF-based forum fork
Last Edit: September 30, 2012, 14:44:43 by Nightwish
#47
Re: minor things |
October 11, 2012, 15:49:24
No sweat :)

Hey um, I wanted to add more activities, and I was wondering about the software design there. Why do you use constant numbers with defines there? isn't that a bad idea for extensibility? Is this just a temporary thing?
#48
Re: minor things |
October 11, 2012, 16:14:53
Hey um, I wanted to add more activities, and I was wondering about the software design there. Why do you use constant numbers with defines there? isn't that a bad idea for extensibility? Is this just a temporary thing?
These are only the predefined ones that must always exist and are part of the default population in the activity_types table. It should be possible (by plugins and hooks) to add custom activity types. The hooks are not yet implemented, but yeah, it's planned to support custom activity types.

Ultimately, the activity_types table defines what activities are available.

     Posted: October 26, 2012, 16:22:35
BTW: Don't wonder about the style looking different every couple of days. I'm just playing around to see how easy/not-so-easy it is to change various parts of the look.

I've also started to play around with SASS but I still prefer the SCSS syntax.
__
Every program has at least one bug and can be shortened by at least one instruction -- from which, by induction, one can deduce that every program can be reduced to a single instruction that doesn't work.
My SMF-based forum fork
#49
Re: minor things |
October 26, 2012, 16:31:20
Also, the geoip plugin is now functional and can hook into the profile summary page and show location info to admins and profile owners (normal users cannot see geoip location for other members though).

It's probably not so useful, just an experiment to see where more hooks are badly needed for the user profile system.
__
Every program has at least one bug and can be shortened by at least one instruction -- from which, by induction, one can deduce that every program can be reduced to a single instruction that doesn't work.
My SMF-based forum fork
#50
Re: minor things |
November 07, 2012, 18:44:50
I've added the current action a user is doing to the profile summary view. If the member is logged in, his last activity field will not only show the timestamp but also the last action he was performing (similar to what the who's online page displays).

If a member has set his online status to "invisible", this information will only be visible to administrators, of course. All others see "hidden".
__
Every program has at least one bug and can be shortened by at least one instruction -- from which, by induction, one can deduce that every program can be reduced to a single instruction that doesn't work.
My SMF-based forum fork